generated from openshift/console-plugin-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patternfly Topology #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmadigan
force-pushed
the
pf-topology
branch
from
October 4, 2024 14:32
a38fc47
to
5ada596
Compare
jasonmadigan
requested review from
david-martin and
R-Lawton
and removed request for
david-martin
October 4, 2024 14:56
jasonmadigan
force-pushed
the
pf-topology
branch
from
October 4, 2024 14:57
5ada596
to
c6f94aa
Compare
R-Lawton
reviewed
Oct 7, 2024
R-Lawton
reviewed
Oct 7, 2024
R-Lawton
reviewed
Oct 7, 2024
jasonmadigan
force-pushed
the
pf-topology
branch
from
October 7, 2024 15:30
c6f94aa
to
b0589e8
Compare
@R-Lawton fixed up |
Signed-off-by: Jason Madigan <[email protected]>
jasonmadigan
force-pushed
the
pf-topology
branch
from
October 7, 2024 16:09
b0589e8
to
0e6f7eb
Compare
Added a small fix, although with how the component works there may be cases where labels can unavoidably overlap. There are options to prevent node overlap, sadly none really for labels |
R-Lawton
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great nice work 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New: Adds support for Patternfly Topology to render our topology.