Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patternfly Topology #87

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Patternfly Topology #87

merged 1 commit into from
Oct 7, 2024

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Oct 4, 2024

New: Adds support for Patternfly Topology to render our topology.

Screenshot 2024-10-04 at 15 55 48

src/components/PolicyTopologyPage.tsx Outdated Show resolved Hide resolved
src/components/PolicyTopologyPage.tsx Show resolved Hide resolved
src/components/PolicyTopologyPage.tsx Show resolved Hide resolved
@jasonmadigan
Copy link
Member Author

@R-Lawton fixed up

@R-Lawton
Copy link
Contributor

R-Lawton commented Oct 7, 2024

Noticed one small thing now with the change to listener links. They text boxes overlap each other with which ever you hover over being in the front
Screenshot 2024-10-07 at 16 47 40

Signed-off-by: Jason Madigan <[email protected]>
@jasonmadigan
Copy link
Member Author

Added a small fix, although with how the component works there may be cases where labels can unavoidably overlap. There are options to prevent node overlap, sadly none really for labels

Copy link
Contributor

@R-Lawton R-Lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great nice work 🎉

@R-Lawton R-Lawton merged commit 6d3cbbc into Kuadrant:main Oct 7, 2024
2 checks passed
@jasonmadigan jasonmadigan deleted the pf-topology branch October 8, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants