Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global picker for: AuthPolicy, TLSPolicy and RateLimitPolicy #97

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Oct 10, 2024

Resolves #92

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fieldId="gateway-select"
isRequired
>
<GatewaySelect selectedGateway={selectedGateway} onChange={setSelectedGateway} />
</FormGroup>
<FormGroup
label={t("CertIssuer Issuer Reference")}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cause of some duplicate labels in the form (the inline elements had same/similar labels)

@R-Lawton
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8135b7b into main Oct 11, 2024
3 checks passed
@jasonmadigan jasonmadigan deleted the namespace-pickers branch October 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Change the namespace selector in the policy create/update views
2 participants