Skip to content

Commit

Permalink
Merge pull request #150 from R-Lawton/naming
Browse files Browse the repository at this point in the history
Refactoring service name and metrics port to match authorino
  • Loading branch information
R-Lawton authored Jul 5, 2024
2 parents e3f28fc + 7b54231 commit 181e4be
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 18 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ local-env-setup: ## Prepare environment to run the operator with "make run"

## Miscellaneous Custom targets
.PHONY: local-setup
local-setup: export IMG := limitador-operator:dev
local-setup: export IMG := localhost/limitador-operator:dev
local-setup: ## Deploy operator in local kind cluster
$(MAKE) local-env-setup
$(MAKE) docker-build
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
creationTimestamp: null
labels:
control-plane: controller-manager
name: limitador-operator-controller-manager-metrics-service
name: limitador-operator-metrics
spec:
ports:
- name: metrics
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ metadata:
capabilities: Basic Install
categories: Integration & Delivery
containerImage: quay.io/kuadrant/limitador-operator:latest
createdAt: "2024-07-02T10:21:19Z"
createdAt: "2024-07-05T11:06:08Z"
operators.operatorframework.io/builder: operator-sdk-v1.32.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
repository: https://github.com/Kuadrant/limitador-operator
Expand Down
1 change: 0 additions & 1 deletion config/default/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ patchesStrategicMerge:
# If you want your controller-manager to expose the /metrics
# endpoint w/o any authn/z, please comment the following line.
# - manager_auth_proxy_patch.yaml
- manager_metrics_patch.yaml

# Mount the controller config file for loading manager configurations
# through a ComponentConfig type
Expand Down
13 changes: 0 additions & 13 deletions config/default/manager_metrics_patch.yaml

This file was deleted.

3 changes: 3 additions & 0 deletions config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ spec:
name: manager
securityContext:
allowPrivilegeEscalation: false
ports:
- name: metrics
containerPort: 8080
livenessProbe:
httpGet:
path: /healthz
Expand Down
2 changes: 1 addition & 1 deletion config/manager/metrics_service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ kind: Service
metadata:
labels:
control-plane: controller-manager
name: controller-manager-metrics-service
name: metrics
namespace: system
spec:
ports:
Expand Down

0 comments on commit 181e4be

Please sign in to comment.