Verbosity level

[eguzki]

What

Deploy limitador with specific verbosity level
Currently, only verbosity level 1 to 4 (both included) are allowed. Any verbosity level out of that range should be rejected

apiVersion: limitador.kuadrant.io/v1alpha1
kind: Limitador
metadata:
  name: limitador-sample
spec:
  verbosity: 2

Verification Steps

dev setup

make local-setup

Deploy the limitador CR with verbosity level set to 2

k apply -f - <<EOF
---
apiVersion: limitador.kuadrant.io/v1alpha1
kind: Limitador
metadata:
  name: limitador-sample
spec:
  verbosity: 2
EOF

Check deployment is correct

kubectl wait --timeout=300s --for=condition=Ready limitador limitador-sample

Should return

limitador.limitador.kuadrant.io/limitador-sample condition met

Check command line

kubectl get deployment/limitador-limitador-sample  -o yaml | yq '.spec.template.spec.containers[0].command'

should look like this

- limitador-server
- -vv
- --http-port
- "8080"
- --rls-port
- "8081"
- /home/limitador/etc/limitador-config.yaml
- memory

Note: -vv has been added to the command line

[codecov-commenter]

Codecov Report

Merging #119 (16c7b03) into main (f6a01e8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   68.62%   68.70%   +0.08%     
==========================================
  Files          16       16              
  Lines        1157     1160       +3     
==========================================
+ Hits          794      797       +3     
  Misses        324      324              
  Partials       39       39              

Flag	Coverage Δ
integration	73.77% <ø> (ø)
unit	66.37% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1alpha1 (u)	100.00% <ø> (ø)
pkg/helpers (u)	∅ <ø> (∅)
pkg/log (u)	31.81% <ø> (ø)
pkg/reconcilers (u)	36.76% <ø> (ø)
pkg/limitador (u)	88.88% <100.00%> (+0.09%)	⬆️
controllers (i)	73.77% <ø> (ø)

Files	Coverage Δ
api/v1alpha1/limitador_types.go	100.00% <ø> (ø)
pkg/limitador/deployment_options.go	93.61% <100.00%> (+0.43%)	⬆️

[eguzki]

@Kuadrant/engineering ready for review!

[KevFan]

Looks good to me ! 👍