Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete outdated upgrade procedures #162

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Sep 30, 2024

No description provided.

@eguzki eguzki requested a review from KevFan September 30, 2024 15:10
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (41baa87) to head (c4098ca).

Files with missing lines Patch % Lines
controllers/limitador_controller.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   84.73%   84.38%   -0.36%     
==========================================
  Files          19       18       -1     
  Lines        1009      967      -42     
==========================================
- Hits          855      816      -39     
+ Misses        102      100       -2     
+ Partials       52       51       -1     
Flag Coverage Δ
integration 78.17% <57.14%> (-0.62%) ⬇️
unit 65.14% <ø> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1alpha1 (u) 100.00% <ø> (ø)
pkg/helpers (u) 80.64% <ø> (-3.23%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) 73.52% <ø> (ø)
pkg/limitador (u) 98.11% <ø> (ø)
controllers (i) 75.25% <57.14%> (-0.49%) ⬇️
pkg/upgrades ∅ <ø> (∅)
Files with missing lines Coverage Δ
controllers/limitador_controller.go 73.73% <57.14%> (+1.08%) ⬆️

... and 2 files with indirect coverage changes

@eguzki eguzki force-pushed the delete-old-upgrade-procedures branch from 7f2bc27 to b0c88eb Compare September 30, 2024 15:14
@eguzki eguzki requested a review from didierofrivia October 1, 2024 07:29
eguzki added 2 commits October 1, 2024 13:08
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
@eguzki eguzki force-pushed the delete-old-upgrade-procedures branch from b0c88eb to c4098ca Compare October 1, 2024 11:08
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

@eguzki eguzki merged commit 641345e into main Oct 1, 2024
16 checks passed
@eguzki eguzki deleted the delete-old-upgrade-procedures branch October 1, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants