Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improve build images job for release tags #169

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Oct 29, 2024

What

New CI workflow named Build and Publish Images For Tag Release that:

  • Skip the bundle build
  • Don't set the BUNDLE_IMG value in the build-catalog
  • Ensure current image values reference the same tag name currently being built
  • Ensure all image references are equal (operator, bundle, catalog)
  • Ensure release version in go code matches git version tag
  • Release version passed in by ldflag

Verification steps: create a release v0.0.100 that should succeed.

Run the GHA Release operator; make sure to fill all the fields:

  • Branch containing the release workflow file: ci-improve-build-images-job-for-release-tag
  • Commit SHA or branch name of the operator to release: ci-improve-build-images-job-for-release-tag
  • Operator version to release (without prefix): 0.0.100
  • Limitador version the operator enables installations of (without prefix) – i.e. 1.6.0

Verify that the build image for release tag workflow is triggered and completes for the new tag

git fetch -p
git push --delete origin v0.0.100
git tag -d v0.0.100
git push --delete origin release-v0.0.100
git branch -D release-v0.0.100

@eguzki eguzki requested a review from didierofrivia October 29, 2024 16:39
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.28%. Comparing base (55430e6) to head (401a347).

❗ There is a different number of reports uploaded between BASE (55430e6) and HEAD (401a347). Click for more details.

HEAD has 25 uploads less than BASE
Flag BASE (55430e6) HEAD (401a347)
unit 11 0
integration 15 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   83.71%   76.28%   -7.44%     
==========================================
  Files          18       18              
  Lines        1210     1210              
==========================================
- Hits         1013      923      -90     
- Misses        150      222      +72     
- Partials       47       65      +18     
Flag Coverage Δ
integration 76.28% <ø> (-1.82%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1alpha1 (u) 90.00% <ø> (-10.00%) ⬇️
pkg/helpers (u) 83.78% <ø> (ø)
pkg/log (u) 61.36% <ø> (-31.82%) ⬇️
pkg/reconcilers (u) 66.33% <ø> (-6.94%) ⬇️
pkg/limitador (u) 87.72% <ø> (-9.93%) ⬇️
controllers (i) 72.01% <ø> (-3.06%) ⬇️
pkg/upgrades ∅ <ø> (∅)

see 11 files with indirect coverage changes

@eguzki eguzki marked this pull request as ready for review October 30, 2024 23:16
@eguzki
Copy link
Contributor Author

eguzki commented Oct 30, 2024

ready for review @didierofrivia

@eguzki eguzki self-assigned this Oct 30, 2024
@eguzki eguzki added kind/enhancement New feature or request size/small labels Oct 30, 2024
@eguzki eguzki requested a review from didierofrivia October 31, 2024 14:52
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to align the way we are building images with the rest of the projects, also clean the workflows and if possible use the same one for every operator.

@eguzki eguzki merged commit 5d29041 into main Nov 5, 2024
17 checks passed
@eguzki eguzki deleted the ci-improve-build-images-job-for-release-tag branch November 5, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request size/small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants