coverage test only on main branch #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
force-pushed
the
coverage-tests
branch
from
ec6dca9 to
83e79e3
Compare
adam-cattermole
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an incompatibility between nightly toolchain and time v0.3.28. This makes coverage measurement a broken task until new
timecrate is released. The fix has already been merged but a new crate has not been release as of today.This PR runs coverage measurement only on
mainbranch, which will keep failing unfortunately. But at least it will not block all the PR's.When the new
timecrate is released, the coverage measurement can be brought back to PR's if we want to check coverage increase/decrease due to the PR changes.