refactor: cross compile for arm64 image build #222
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| ./target | ||
| Dockerfile* | ||
| *.swp | ||
| .dockerignore | ||
| .gitignore | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,6 @@ on: | |
| tags: ['*'] | ||
|
|
||
| env: | ||
| IMG_REGISTRY_HOST: quay.io | ||
| IMG_REGISTRY_ORG: kuadrant | ||
| MAIN_BRANCH_NAME: main | ||
|
|
@@ -17,43 +16,99 @@ jobs: | |
| build: | ||
| name: Build | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - dockerfile: Dockerfile | ||
| platform: linux/amd64 | ||
| scope: build-amd | ||
| - dockerfile: Dockerfile.aarch64 | ||
| platform: linux/arm64 | ||
| scope: build-arm | ||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Docker meta | ||
| id: meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: | | ||
| ${{ env.IMG_REGISTRY_HOST }}/${{ env.IMG_REGISTRY_ORG }}/limitador | ||
| - name: Login to container registry | ||
| uses: docker/login-action@v2 | ||
| with: | ||
| username: ${{ secrets.IMG_REGISTRY_USERNAME }} | ||
| password: ${{ secrets.IMG_REGISTRY_TOKEN }} | ||
| registry: ${{ env.IMG_REGISTRY_HOST }} | ||
| - name: Build and push by digest | ||
| id: build | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| build-args: | | ||
| GITHUB_SHA=${{ github.sha }} | ||
| cache-from: type=gha,scope=${{ matrix.scope }} | ||
| cache-to: type=gha,mode=max,scope=${{ matrix.scope}} | ||
| outputs: type=image,name=${{ env.IMG_REGISTRY_HOST }}/${{ env.IMG_REGISTRY_ORG }}/limitador,push-by-digest=true,name-canonical=true,push=true | ||
| file: ${{ matrix.dockerfile }} | ||
| platforms: | | ||
| ${{ matrix.platform }} | ||
| provenance: false | ||
|
There was a problem hiding this comment. Cross compiling can produce unknown manifests
Setting |
||
| - name: Export digest | ||
| run: | | ||
| mkdir -p /tmp/digests | ||
| digest="${{ steps.build.outputs.digest }}" | ||
| touch "/tmp/digests/${digest#sha256:}" | ||
| - name: Upload digest | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: digests | ||
| path: /tmp/digests/* | ||
| if-no-files-found: error | ||
| retention-days: 1 | ||
| merge: | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - build | ||
| steps: | ||
| - name: Download digests | ||
| uses: actions/download-artifact@v3 | ||
| with: | ||
| name: digests | ||
| path: /tmp/digests | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Docker meta | ||
| id: meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: | | ||
| ${{ env.IMG_REGISTRY_HOST }}/${{ env.IMG_REGISTRY_ORG }}/limitador | ||
| tags: | | ||
| # SHA tag for main branch | ||
| type=raw,value=${{ github.sha }},enable=${{ github.ref_name == env.MAIN_BRANCH_NAME }} | ||
| # set latest tag for main branch | ||
| type=raw,value=latest,enable=${{ github.ref_name == env.MAIN_BRANCH_NAME }} | ||
| # set ref name tag for non-main branches | ||
| type=raw,value=${{ github.ref_name }},enable=${{ github.ref_name != env.MAIN_BRANCH_NAME }} | ||
| - name: Login to container registry | ||
| uses: docker/login-action@v2 | ||
| with: | ||
| username: ${{ secrets.IMG_REGISTRY_USERNAME }} | ||
| password: ${{ secrets.IMG_REGISTRY_TOKEN }} | ||
| registry: ${{ env.IMG_REGISTRY_HOST }} | ||
| - name: Create manifest list and push | ||
| working-directory: /tmp/digests | ||
| run: | | ||
| docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \ | ||
| $(printf '${{ env.IMG_REGISTRY_HOST }}/${{ env.IMG_REGISTRY_ORG }}/limitador@sha256:%s ' *) | ||
| - name: Inspect image | ||
| run: | | ||
| docker buildx imagetools inspect ${{ env.IMG_REGISTRY_HOST }}/${{ env.IMG_REGISTRY_ORG }}/limitador:${{ steps.meta.outputs.version }} | ||
| - name: Smoke Test | ||
| run: | | ||
| docker run --rm -t ${{ env.IMG_REGISTRY_HOST }}/${{ env.IMG_REGISTRY_ORG }}/limitador:${{ steps.meta.outputs.version }} limitador-server --help | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which labels are set by default from the output of the meta step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the JSON output for this build step (taken from the workflow logs):
{ "tags": [ "quay.io/kuadrant/limitador:quicker-workflow" ], "labels": { "org.opencontainers.image.created": "2024-01-08T15:23:11.687Z", "org.opencontainers.image.description": "Rate limiter", "org.opencontainers.image.licenses": "Apache-2.0", "org.opencontainers.image.revision": "a39035119c7899901dfc785e[59](https://github.com/Kuadrant/limitador/actions/runs/7449493828/job/20266248072?pr=222#step:4:68)380d52b9b11986", "org.opencontainers.image.source": "https://github.com/Kuadrant/limitador", "org.opencontainers.image.title": "limitador", "org.opencontainers.image.url": "https://github.com/Kuadrant/limitador", "org.opencontainers.image.version": "quicker-workflow" }, "annotations": [ "manifest:org.opencontainers.image.created=2024-01-08T15:23:11.[68](https://github.com/Kuadrant/limitador/actions/runs/7449493828/job/20266248072?pr=222#step:4:77)7Z", "manifest:org.opencontainers.image.description=Rate limiter", "manifest:org.opencontainers.image.licenses=Apache-2.0", "manifest:org.opencontainers.image.revision=a39035119c7899901dfc785e59380d52b9b11986", "manifest:org.opencontainers.image.source=https://github.com/Kuadrant/limitador", "manifest:org.opencontainers.image.title=limitador", "manifest:org.opencontainers.image.url=https://github.com/Kuadrant/limitador", "manifest:org.opencontainers.image.version=quicker-workflow" ] }