Simplify image builds by using QEMU to do multi-arch builds #350
Conversation
| tags: | ||
| - "*" |
There was a problem hiding this comment.
I think we need this, as that's how we release, no? @didierofrivia
tags could be only v[0-9]+\.[0-9]+\.[0-9]+(-.*)? or something tho
There was a problem hiding this comment.
We could reduce the scope to - 'v*.*.*' tags
| workflow_dispatch: | ||
| push: | ||
| tags: | ||
| - "*" |
There was a problem hiding this comment.
Added another workflow for releases, in this case we build both archs.
chirino
force-pushed
the
docker-builds
branch
3 times, most recently
from
45b4a78 to
7b2f822
Compare
…e they are slow, only do the multi-arch builds for releases. Also support passing cargo build args to the Docker image builder, allowing us to enable all features. Signed-off-by: Hiram Chirino <[email protected]>
|
If I understand this correctly, image is not being built on PR's. Is this something we want? Building an image is kind of a test as well that either passes or fails. |
I realize that the image building on PR's was removed a while ago. |
|
I'd say that going back to quemu for the default building is not ideal as the default build job, I'd rather add it as a different |
|
ok. closing PR, maybe revisit later. |
but since they are slow, only do the multi-arch builds for releases.
Also support passing cargo build args to the Docker image builder, allowing us to enable all features.