Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Fix google dns for records with multiple targets #575

Conversation

mikenairn
Copy link
Member

fixes #563

Fix toResourceRecordSets in google dns provider to make sure that only a single record set is created for each unique dnsName. Issue was introduced here
c57366e#diff-eea59a6fb9851390f6210a03f57ba88ea1628c32d20d526998600135a1642bedR494

Fix `toResourceRecordSets` in google dns provider to make sure that ony
a single record set is created for each unique dnsName. Issue was
introduced here
Kuadrant@c57366e#diff-eea59a6fb9851390f6210a03f57ba88ea1628c32d20d526998600135a1642bedR494
@mikenairn mikenairn temporarily deployed to e2e-internal September 19, 2023 12:16 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maleck13, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maleck13
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2023
@maleck13 maleck13 added this pull request to the merge queue Sep 19, 2023
Merged via the queue into Kuadrant:main with commit 89c27b6 Sep 19, 2023
@david-martin
Copy link
Member

Fix verified in local cluster.
Logs show a single record for the weighted round robin records being created.
No 409 conflict.

2023-09-19T15:49:01Z	DEBUG	google-dns	Change zone	{"project": "it-cloud-gcp-rd-midd-san", "zone": "davmarti-google-hcpapps-net", "batch": 0}
2023-09-19T15:49:01Z	DEBUG	google-dns	Add records	{"project": "it-cloud-gcp-rd-midd-san", "name": "2c71gf.lb-4ej5le.myapp11.davmarti.google.hcpapps.net.", "type": "A", "Rrdatas": ["172.31.200.0"], "RoutingPolicy": null, "ttl": 60}
2023-09-19T15:49:01Z	DEBUG	google-dns	Add records	{"project": "it-cloud-gcp-rd-midd-san", "name": "default.lb-4ej5le.myapp11.davmarti.google.hcpapps.net.", "type": "CNAME", "Rrdatas": [], "RoutingPolicy": {"wrr":{"items":[{"rrdatas":["2c71gf.lb-4ej5le.myapp11.davmarti.google.hcpapps.net."],"weight":120},{"rrdatas":["lrnse3.lb-4ej5le.myapp11.davmarti.google.hcpapps.net."],"weight":120}]}}, "ttl": 60}
2023-09-19T15:49:01Z	DEBUG	google-dns	Add records	{"project": "it-cloud-gcp-rd-midd-san", "name": "lb-4ej5le.myapp11.davmarti.google.hcpapps.net.", "type": "CNAME", "Rrdatas": [], "RoutingPolicy": {"geo":{"items":[{"location":"europe-west1","rrdatas":["default.lb-4ej5le.myapp11.davmarti.google.hcpapps.net."]}]}}, "ttl": 300}
2023-09-19T15:49:01Z	DEBUG	google-dns	Add records	{"project": "it-cloud-gcp-rd-midd-san", "name": "lrnse3.lb-4ej5le.myapp11.davmarti.google.hcpapps.net.", "type": "A", "Rrdatas": ["172.31.201.0"], "RoutingPolicy": null, "ttl": 60}
2023-09-19T15:49:01Z	DEBUG	google-dns	Add records	{"project": "it-cloud-gcp-rd-midd-san", "name": "myapp11.davmarti.google.hcpapps.net.", "type": "CNAME", "Rrdatas": ["lb-4ej5le.myapp11.davmarti.google.hcpapps.net."], "RoutingPolicy": null, "ttl": 300}

@mikenairn mikenairn deleted the 563-fix_google_record_set_creation_with_multiple_targets branch September 25, 2023 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The DNS provider failed to ensure the record: googleapi: Error 409 (after delete/readd listener)
3 participants