small fix for gateways being deleted after placement deleted

[maleck13]

fixes #420

Note

This is a fix but not a full fix.

The following also need to be addressed in separate issues

• When a placement is deleted so is a placement decision the gateway should be removed from the placed clusters in this case
• When the placement label is changed on the gateway, the old gateways on previous clusters should be removed

I am working on the above as a larger change set.

[sergioifg94]

I'm trying to reproduce the error but instead of the Gateway being deleted it's status is changing to Unknown, is that the expected behavour or am I missing something?

[maleck13]

Yes the gateway is not deleted and the status updates to unknown (different issue around the error stuff)

[maleck13]

@sergioifg94 to verify

• use quick start
• create a gateway and place it
• delete the placement
• check the status (it should have a clear error now)
• delete the gateway (it should not get stuck but should be removed)

[maleck13]

taking a look at the integration test failure

[sergioifg94]

I'm still not able to verify it. The status changes to Unknown but I don't see an error message. This is how the status looks like

status:                                                                                                                                               
  addresses:                                                                                                                                          
  - type: IPAddress                                                                                                                                   
    value: 172.31.200.0                                                                                                                               
  conditions:                                                                                                                                         
  - lastTransitionTime: "2023-09-20T09:56:08Z"                                                                                                        
    message: Deployed gateway to the cluster                                                                                                          
    observedGeneration: 1                                                                                                                             
    reason: Accepted                                                                                                                                  
    status: "True"                                                                                                                                    
    type: Accepted                                                                                                                                    
  - lastTransitionTime: "2023-09-20T09:56:08Z"                                                                                                        
    message: Deployed gateway to the cluster                                                                                                          
    observedGeneration: 1                                                                                                                             
    reason: ResourcesAvailable                                                                                                                        
    status: "True"                                                                                                                                    
    type: Scheduled                                                                                                                                   
  - lastTransitionTime: "2023-09-20T09:54:15Z"                                                                                                        
    message: Gateway valid, assigned to service(s) prod-web-istio.kuadrant-multi-cluster-gateways.svc.cluster.local:443                               
    observedGeneration: 1                                                                     
    reason: ListenersValid                                                                    
    status: "True"                                                                            
    type: Ready                                                                               
  listeners:                                                                                  
  - attachedRoutes: 0                                                                         
    conditions:                                                                                                                                                                              
    - lastTransitionTime: "2023-09-20T09:54:11Z"                                              
      message: No errors found                                                                
      observedGeneration: 1                                                                   
      reason: Accepted                                                                        
      status: "True"                                                                          
      type: Accepted                                                                          
    - lastTransitionTime: "2023-09-20T09:54:11Z"                                              
      message: No errors found                                                                
      observedGeneration: 1                                                                   
      reason: NoConflicts                                                                     
      status: "False"                                                                         
      type: Conflicted                                                                        
    - lastTransitionTime: "2023-09-20T09:54:11Z"                                              
      message: No errors found                                                                
      observedGeneration: 1                                                                   
      reason: Attached                                                                        
      status: "False"                                                                         
      type: Detached                                                                          
    - lastTransitionTime: "2023-09-20T09:54:11Z"                                              
      message: No errors found                                                                
      observedGeneration: 1                                                                   
      reason: Programmed                                                                      
      status: "True"                                                                          
      type: Programmed                                                                        
    - lastTransitionTime: "2023-09-20T09:54:11Z"                                              
      message: No errors found                                                                
      observedGeneration: 1                                                                   
      reason: Ready                                                                           
      status: "True"                                                                          
      type: Ready                                                                             
    - lastTransitionTime: "2023-09-20T09:54:11Z"                                              
      message: No errors found                                                                
      observedGeneration: 1                                                                   
      reason: ResolvedRefs                                                                    
      status: "True"                                                                          
      type: ResolvedRefs                                                                      
    name: specific                                                                            
    supportedKinds:                                                                           
    - group: gateway.networking.k8s.io                                                        
      kind: HTTPRoute  

I'm deleting the placement by running

kubectl delete placement -n multi-cluster-gateways http-gateway 

[maleck13]

looks like you are looking at the istio instance rather than the control plane definiton?

[sergioifg94]

Tricked by the autocomplete in the terminal

 - lastTransitionTime: "2023-09-20T09:56:00Z"
    message: 'current state of the gateway is unknown error: failed to place gateway
      : no PlacementDecisions found for placement http-gateway via label selector:
      map[cluster.open-cluster-management.io/placement:http-gateway] error: PlacementDecision
      "http-gateway" not found'

[sergioifg94]

Verified that the status gets an error message and the gateway can be deleted without getting stuck
/lgtm

[maleck13]

/lgtm

[openshift-ci]

@maleck13: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mikenairn]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maleck13, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maleck13,mikenairn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment