Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Update tls docs #584

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Sep 20, 2023

Update the LE Issuer example to reference all AWS credentials from the secret. The version of cert-manager that is installed by default in local development(v1.12.2) should have these options.

Update the LE Issuer example to use reference all AWS credentials from
the secret. The version of cert-manager that is installed by default in
local development(v1.12.2) should have these options.
@mikenairn
Copy link
Member Author

The issue i was seeing with this was caused by the wrong version of cert manager being installed locally see #582

@mikenairn mikenairn mentioned this pull request Sep 20, 2023
@jasonmadigan
Copy link
Member

Nice one

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasonmadigan,mikenairn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonmadigan
Copy link
Member

jasonmadigan commented Sep 20, 2023

Manually merging. Will trigger a docs redeploy.

Deploying: https://github.com/Kuadrant/docs.kuadrant.io/actions/runs/6247887957

@jasonmadigan jasonmadigan merged commit 72d99cc into Kuadrant:main Sep 20, 2023
@mikenairn mikenairn deleted the update_tls_policy_doc branch September 20, 2023 11:26
@jasonmadigan
Copy link
Member

@laurafitzgerald ^ fyi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants