Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Gateway api state metrics #598

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

Ygnas
Copy link
Collaborator

@Ygnas Ygnas commented Sep 25, 2023

Closes: #438

Verification

  1. export MGC_BRANCH=gateway-api-state-metrics

    Before running quickstart-metrics make sure that resources exist Multicluster Gateways Walkthrough

  2. curl -sS https://raw.githubusercontent.com/Ygnas/multicluster-gateway-controller/gateway-api-state-metrics/hack/quickstart-metrics.sh | bash

    Note: The default login credentials for Grafana are admin/admin. You may need to accept the non-CA signed certificate to proceed.

  3. Should be able to see the new dashboards Grafana
    arch

@Ygnas Ygnas temporarily deployed to e2e-internal September 25, 2023 11:01 — with GitHub Actions Inactive
@Ygnas Ygnas requested a review from david-martin September 25, 2023 11:03
@Ygnas Ygnas marked this pull request as ready for review September 25, 2023 11:25
@Ygnas Ygnas force-pushed the gateway-api-state-metrics branch from 1e9e0c4 to 6857e24 Compare September 25, 2023 14:31
@Ygnas Ygnas temporarily deployed to e2e-internal September 25, 2023 14:31 — with GitHub Actions Inactive
@Ygnas Ygnas force-pushed the gateway-api-state-metrics branch from 6857e24 to 25a4198 Compare September 25, 2023 16:08
@Ygnas Ygnas temporarily deployed to e2e-internal September 25, 2023 16:08 — with GitHub Actions Inactive
@Ygnas Ygnas force-pushed the gateway-api-state-metrics branch from 25a4198 to be12f30 Compare September 25, 2023 16:13
@Ygnas Ygnas force-pushed the gateway-api-state-metrics branch from be12f30 to 4d36db3 Compare September 25, 2023 16:28
@Ygnas Ygnas temporarily deployed to e2e-internal September 25, 2023 16:28 — with GitHub Actions Inactive
@Ygnas Ygnas requested a review from david-martin September 26, 2023 10:05
@Ygnas Ygnas force-pushed the gateway-api-state-metrics branch from 4d36db3 to dbd9106 Compare September 26, 2023 10:59
@Ygnas Ygnas temporarily deployed to e2e-internal September 26, 2023 10:59 — with GitHub Actions Inactive
@david-martin
Copy link
Member

/lgtm
/approve

OK to land after the release merge blocker.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@david-martin david-martin merged commit 3bae2e8 into Kuadrant:main Sep 27, 2023
9 checks passed
@david-martin
Copy link
Member

Merging despite the merge blocker issue for the release as these changes are isolated to the quickstart metrics script and the metrics walkthrough.
No other testing, expect for what's been done for this issue, has been executed for the release so it makes sense to have tested and verified content for metrics for the release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gateway-api-state-metrics & dashboard to the metrics walkthrough
2 participants