Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Gh 587 #606

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Gh 587 #606

merged 2 commits into from
Oct 2, 2023

Conversation

philbrookes
Copy link
Contributor

  • add TLS Policy integration tests
  • Minor tweaks to tests to stop flaky failures and fix issue with wildcard listeners in utility package.

verification

  • see PR tests pass

@philbrookes philbrookes temporarily deployed to e2e-internal September 26, 2023 14:48 — with GitHub Actions Inactive
@philbrookes
Copy link
Contributor Author

related to integration sections of: #587

laurafitzgerald
laurafitzgerald reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@laurafitzgerald laurafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question inline.

test/integration/tlspolicy_controller_test.go Outdated Show resolved Hide resolved
@philbrookes philbrookes temporarily deployed to e2e-internal September 27, 2023 13:59 — with GitHub Actions Inactive
@philbrookes philbrookes temporarily deployed to e2e-internal September 28, 2023 13:26 — with GitHub Actions Inactive
@philbrookes philbrookes temporarily deployed to e2e-internal September 28, 2023 14:08 — with GitHub Actions Inactive
@philbrookes philbrookes temporarily deployed to e2e-internal September 28, 2023 14:12 — with GitHub Actions Inactive
@philbrookes philbrookes temporarily deployed to e2e-internal September 28, 2023 14:14 — with GitHub Actions Inactive
@mikenairn
Copy link
Member

Question about one of the gomega matchers being used, but other than that, changes look good.

@philbrookes philbrookes temporarily deployed to e2e-internal September 28, 2023 15:40 — with GitHub Actions Inactive
@philbrookes philbrookes temporarily deployed to e2e-internal October 2, 2023 08:19 — with GitHub Actions Inactive
@mikenairn
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikenairn, philbrookes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikenairn,philbrookes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@philbrookes philbrookes merged commit 04de469 into Kuadrant:main Oct 2, 2023
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laurafitzgerald laurafitzgerald laurafitzgerald left review comments

@mikenairn mikenairn mikenairn left review comments

Assignees

@mikenairn mikenairn

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philbrookes @mikenairn @laurafitzgerald