This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
remove http check for wildcard certificate in favour of checking certificates #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurafitzgerald
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
test-wildcard-e2e-test
branch
from
d863a04 to
d8ee8f8
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
laurafitzgerald
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
laurafitzgerald
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
test-wildcard-e2e-test
branch
from
d8ee8f8 to
25c66d0
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
laurafitzgerald
force-pushed
the
test-wildcard-e2e-test
branch
from
25c66d0 to
92615d8
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
laurafitzgerald
changed the title
laurafitzgerald
force-pushed
the
test-wildcard-e2e-test
branch
from
92615d8 to
3dfbf32
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
mikenairn
reviewed
Nov 9, 2023
mikenairn
reviewed
Nov 9, 2023
laurafitzgerald
force-pushed
the
test-wildcard-e2e-test
branch
from
3dfbf32 to
7911f0b
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
mikenairn
reviewed
Nov 9, 2023
laurafitzgerald
force-pushed
the
test-wildcard-e2e-test
branch
from
7911f0b to
44cdfe5
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
remove tls checks on https request improve syntax of some tests
laurafitzgerald
force-pushed
the
test-wildcard-e2e-test
branch
from
44cdfe5 to
cae0ba0
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
|
I think we need to look at these tests a bit and decide what the responsibility of each test suite (integration/e2e) is as some of the checks we are doing in the e2e look like the might be better elsewhere. Also probably want to look at creating separate more focused e2e test files for the TLS specific tests. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laurafitzgerald, mikenairn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$subject
As discussed here -> https://kubernetes.slack.com/archives/C05J0D0V525/p1699520931987239