Update e2e GH Workflow #675
Conversation
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
mikenairn
force-pushed
the
update_e2e_gh_workflow
branch
from
7e0552f to
84c9b96
Compare
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
Add TEST_MANAGED_ZONE_NAME env var to e2e test suite steps. This will be required for Kuadrant#636, but adding these here now to make life easier testing that PR. Add log to show image for mgc-controller-manager and mgc-policy-controller
mikenairn
force-pushed
the
update_e2e_gh_workflow
branch
from
84c9b96 to
24ec7b6
Compare
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
| @@ -68,6 +68,8 @@ jobs: | |||
| - name: Deploy | |||
| run: | | |||
| make docker-build-gateway-controller kind-load-gateway-controller docker-build-policy-controller kind-load-policy-controller deploy-gateway-controller | |||
| kubectl --context kind-mgc-control-plane -n multicluster-gateway-controller-system get deployments/mgc-controller-manager -o yaml | yq .spec.template.spec.containers[0].image | |||
There was a problem hiding this comment.
I didn't see this log in the e2e test run. I would have expected to see it after line 254 and before 256 below. Is that an indication something isn't running as expected?
There was a problem hiding this comment.
ah i think this would be expected.
the config changes need to merge before being applied right?
There was a problem hiding this comment.
Yeah, i just realised we won't see it until it's merged as it's running the version from main.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laurafitzgerald, mikenairn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add TEST_MANAGED_ZONE_NAME env var to e2e test suite steps. This will be required for
#636, but adding these here now to make life easier testing that PR.
Add log to show image for mgc-controller-manager and mgc-policy-controller