This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Dns refactor #780
Merged
Dns refactor #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of changes required(mostly) to isolate the dns code from the policy and gateway logic in preparation for moving it to it's own repo. Provider health checks were removed from the aws dns provider implementation. These have been replaced by provder agnostic health checks and are no longer a supported solution. DNS provider implementations are moved into a provider package (dns/provider) along with all other dns provider related interfaces and types. Matches external-dns layout and naming and how we want future providers to be added. Updates the dns provider factory to have each provider register its constructor with the factory on init. Adds fake provider and factory for testing and updates field names in reconcilers to better represent what the Factory resource is (DNSProvider -> ProviderFactory). Factory method (ProviderFor) now expects a resource implementing the ProviderAccessor interface. Move common dns consts and types into api (DefaultWeight, DefaultGeo, WildcardGeo, GeoCode ), remove redundant code from DNSRecord and make receiver name consistent. Added common pkg for consistency with kuadrant-operator and moved target and gateway wrapper resources into here.
Removes the dnspolicy demo docs as they are always becoming out of date and as long as its here it feels like it needs to be kept up to date.
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
This was referenced Feb 1, 2024
The contents of the dns package will all be moved to the new dns controller component as top level packages:
```
.
├── controller
└── pkg
├── health
└── provider
├── aws
├── fake
└── google
```
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
maleck13
approved these changes
Feb 1, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maleck13, mikenairn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of changes required(mostly) to isolate the dns code from the policy and gateway logic in preparation for moving it to it's own repo.
Provider health checks were removed from the aws dns provider implementation. These have been replaced by provider agnostic health checks and are no longer a supported solution.
DNS provider implementations are moved into a provider package(dns/provider) along with all other dns provider related interfaces and types. Matches external-dns layout and naming and how we want future providers to be added.
Updates the dns provider factory to have each provider register its constructor with the factory on init. Adds fake provider and factory for testing and updates field names in reconcilers to better represent what the Factory resource is (DNSProvider -> ProviderFactory). Factory method (ProviderFor) now expects a resource implementing the ProviderAccessor interface.
Note: These changes were based on how certmanager implements registration and a factory for Issuers and seemed like a nice solution. Also gets round some import cycle issues i was having with the refactor.
Move common dns consts and types into api (DefaultWeight, DefaultGeo, WildcardGeo, GeoCode ), remove redundant code from DNSRecord and make receiver name consistent. Added common pkg for consistency with kuadrant-operator and moved target and gateway wrapper resources into here.
Move health package into dns/health. The contents of the dns package will all be moved to the new dns controller component as top level packages: