Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Unified kuadrant - Remove TLSPolicy and DNSPolicy #785

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Unified kuadrant - Remove TLSPolicy and DNSPolicy #785

merged 2 commits into from
Feb 21, 2024

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Feb 8, 2024 •
edited
Loading

close #767 #766 #784

Removes all dns and tls related resources.

  • Remove dnspolicy, tlspolicy, dnsrecord, dnshealth and managedzone api and reconcilers
  • Remove all policy-controller related config and make targets
  • Adds the kuadrant-operator as a dependency of the MGC operator installation and is installed on the OCM hub cluster during local-setup.

Verification

Tested with local-setup and e2e tests.

Requires

@openshift-ci openshift-ci bot added the approved label Feb 8, 2024
maleck13
maleck13 reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes all look fine. Just wondering if we need to review where stuff for cert-manager is used and if that should also be removed?

@mikenairn mikenairn mentioned this pull request Feb 9, 2024
Closed
8 tasks
@mikenairn
Unified Kuadrant
1188e20 
* Remove dnspolicy, tlspolicy, dnsrecord, dnshealth and managedzone api and reconcilers
* Remove all policy-controller related config and make targets
@mikenairn mikenairn marked this pull request as ready for review February 21, 2024 09:38
@mikenairn
Add kuadrant operator install to local-setup
f1ff311 
Adds the kuadrant-operator as a dependency of the MGC operator
installation and is installed on the OCM hub cluster during local-setup.

ci: add workflow_dispatch to e2e
maleck13
maleck13 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went through multi-cluster walkthrough and quick start all worked as expected

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maleck13, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maleck13 maleck13 merged commit 8291d5d into main Feb 21, 2024
8 of 10 checks passed
@maleck13
Copy link
Contributor

by passed e2e as this needs to be merged for them to start passing

@mikenairn mikenairn deleted the unified_kuadrant branch February 21, 2024 14:54
This was referenced Feb 21, 2024
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maleck13 maleck13 maleck13 approved these changes

Assignees
No one assigned
Labels
approved
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move DNSPolicy to Kuadrant Operator
3 participants
@mikenairn @maleck13 @openshift-merge-robot