feat: more Gateway API kind wrappers #16

KevFan · 2024-08-01T11:13:59Z

Description

Closes: #11

Adds wrappers the the following so they can be used in the topology as targetable / object / policy:
- gateway.networking.k8s.io/v1
  - GRPCRoute (targetable)
- gateway.networking.k8s.io/v1beta1
  - ReferenceGrant (object)
- gateway.networking.k8s.io/v1alpha3
  - BackendTLSPolicy (policy)
- gateway.networking.k8s.io/v1alpha2
  - TCPRoute (targetable)
  - TLSRoute (targetable)
  - UDPRoute (targetable)
  - BackendLBPolicy (policy)
- v1 (core)
  - Namespace (targetable)
Additionally adds the LinkFunc's for the new xRoute kinds from above as part of the Gateway API Topology
- These were not added to controller/topology_builder for now, unless we want to enable these already as part of the controller package?
- The link function for Namespace as a targetable in the topolgy was not added as part of this PR as this seems not as straightforward which might require some deeper considerations such as:
  - Will Namespace be also a parent to Gateway since Gateway is namespace scoped? (i.e. Gateway will have both GatewayClass and Namespace as parents ). Who will take precedence in this case?
  - Namespace can be a parent of whatever the resource in its namespace which are also targetable, does this matter? i.e. a Route in a namespace may not have a Gateway since a Route can use a Gateway from a different namespace as a parent reference

machinery/gateway_api_topology_test.go

machinery/core_types.go

machinery/gateway_api_topology.go

machinery/gateway_api_types.go

controller/topology_builder.go

guicassolato · 2024-08-06T16:10:38Z

controller/topology_builder.go

 		httpRoute, ok := obj.(*gwapiv1.HTTPRoute)
 		if !ok {
 			return nil, false
 		}
 		return httpRoute, true
 	})

-	services := lo.FilterMap(lo.Values(objs[schema.GroupKind{Group: core.GroupName, Kind: "Service"}]), func(obj RuntimeObject, _ int) (*core.Service, bool) {
+	services := lo.FilterMap(lo.Values(objs[machinery.ServiceGroupKind]), func(obj RuntimeObject, _ int) (*core.Service, bool) {


Let's also add the new types of resources here?

I was originally thinking of just adding the new resource types to the machinary package, and once we feel it is stable/usable enough, we'll add it here then 🤔

Although I don't feel strongly about this if you prefer them to be added here also. Let me know 👍

KevFan · 2024-08-15T15:02:02Z

There seems to a failing unit test that I'll look into, for some reason the same test is passing locally but failing on the CI now 🤷

KevFan · 2024-08-16T07:58:38Z

Still looking into the unit test failure, it's failing locally for me now. Seems to an issue that surfaced after the new dot engine PR was merged. Service -> ServicePort is linked multiple times now on the graph for some reason 🤔

machinery/gateway_api_topology.go

Signed-off-by: KevFan <[email protected]>

machinery/core_types.go

machinery/gateway_api_types.go

guicassolato

Left a minor suggestion only for completeness, but excellent work overall. Thanks!

Signed-off-by: KevFan <[email protected]>

KevFan changed the title ~~[wip] Issues/11~~ [wip] feat: more Gateway API kind wrappers Aug 1, 2024

KevFan force-pushed the issues/11 branch 3 times, most recently from 8c75a39 to a314211 Compare August 6, 2024 10:37

KevFan changed the title ~~[wip] feat: more Gateway API kind wrappers~~ feat: more Gateway API kind wrappers Aug 6, 2024

KevFan marked this pull request as ready for review August 6, 2024 13:57

KevFan requested review from Boomatang and guicassolato August 6, 2024 14:00