tests: controller integration tests #27
Conversation
guicassolato
force-pushed
the
controller-integration-tests
branch
from
5013870 to
e78b382
Compare
Signed-off-by: Guilherme Cassolato <[email protected]>
guicassolato
force-pushed
the
controller-integration-tests
branch
from
e78b382 to
35eb125
Compare
| cancel() | ||
| } | ||
| }() | ||
| time.Sleep(3 * time.Second) |
There was a problem hiding this comment.
What is the reason for this sleep. Would it not be safer to set up a wait group for the go routines and exit once all have finished.
There was a problem hiding this comment.
The goroutine won't finish. It only finishes when the context is done (canceled), hence the wait and the deferred call to cancel().
The wait is mainly to give the manager time to start processes such as the metrics service and others. This is more relevant to controller-runtime managed controllers than to informers-based ones. The latter boot up significantly quicker.
| cancel() | ||
| } | ||
| }() | ||
| time.Sleep(3 * time.Second) |
There was a problem hiding this comment.
Again would a wait group be better here.
|
|
||
| .PHONY: test-unit | ||
| test-unit: ## Run unit tests. | ||
| go test -tags=unit -v ./... |
There was a problem hiding this comment.
In general I don't like using the -v by default when it is being run in automation, but as there is very limited logs currently I am okay with this.
Add proper integration tests for the
controllerpackage.TestStartControllerManagedtest caseAdded target for running the tests:
Other targets introduced:
make test