fix: topology all can cause race #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
added a commit
to Kuadrant/kuadrant-operator
that referenced
this pull request
Oct 24, 2024
bump policy-machinery module Kuadrant/policy-machinery#45 Signed-off-by: Michael Nairn <[email protected]>
mikenairn
added a commit
to Kuadrant/kuadrant-operator
that referenced
this pull request
Oct 24, 2024
bump policy-machinery module Kuadrant/policy-machinery#45 Signed-off-by: Michael Nairn <[email protected]>
KevFan
approved these changes
Oct 24, 2024
Topology.All() was incorrectly modifying the existing topology map instead of copying it which can cause a race `fatal error: concurrent map read and map write` under normal usage. Signed-off-by: Michael Nairn <[email protected]>
mikenairn
force-pushed
the
fix_topology_all_race
branch
from
4983c5d to
d87b3ad
Compare
mikenairn
added a commit
to mikenairn/kuadrant-operator
that referenced
this pull request
Oct 24, 2024
Requires this fix Kuadrant/policy-machinery#45 Signed-off-by: Michael Nairn <[email protected]>
mikenairn
added a commit
to mikenairn/kuadrant-operator
that referenced
this pull request
Oct 24, 2024
Requires this fix Kuadrant/policy-machinery#45 Signed-off-by: Michael Nairn <[email protected]>
mikenairn
added a commit
to mikenairn/kuadrant-operator
that referenced
this pull request
Oct 25, 2024
Requires this fix Kuadrant/policy-machinery#45 Signed-off-by: Michael Nairn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topology.All() was incorrectly modifying the existing topology map instead of copying it which can cause a race
fatal error: concurrent map read and map writeunder normal usage.