added maxDraggingOffset property #215
Conversation
|
Would love this... |
|
Sorry for the so late review. Can you please add some easing function there? I.e. when you drag close to the offset, drag velocity goes down to zero near the offset value. |
…ve-side-menu # By Kureev Alexey (5) and others # Via GitHub (6) and Alexey (1) * 'master' of github.com:react-native-community/react-native-side-menu: Update Menu.js Release v0.20.1. landscape mode after rotating fix Remove --projectRoots Update example Release v0.20.0. cleanup whitespace add documentation for onMove Add optional onMove method for handling animations Update README.md If isOpen isn't set, don't respect its value when props change. 0.19.0 Replace 'extends Component' to 'extends React.Component' Added React as devDep, React and React.Component loaded from react rather than react-native Conflicts: index.js
|
@Kureev are you planning to merge this? |
* 'master' of github.com:acresta88/react-native-side-menu: bug fix fixing bug with offset bug fix forcing the menu to re-calculate the percentage Conflicts: index.js
|
? |
|
@lukas1994 Hi, unfortunately I didn't have time to add the easing function that @Kureev asked for, the new commits above where just because of some problem on android when locking the orientation, so quite unrelated to the dragging offset. So either you wait a bit more (probably new year) for it, or maybe @Kureev can add that the maxDraggingOffset property without easing function :) |
|
For anyone that's still looking for this - I've forked and added this functionality to https://github.com/gsdatta/react-native-side-menu. I also converted it to typescript. I have yet to get it onto NPM, but if anyone wants to open a PR to set up the package correctly I'm glad to publish it. |
added maxDraggingOffset property to set the maximum value for the dragging gesture.
To avoid that the user can drag more than the menu size and show a white unwanted background.
By default set to 0 so that the user can drag only until the full menu is shown, but settable in case that dragging behaviour should be like before.