This repository has been archived by the owner on Sep 13, 2020. It is now read-only.
Address RTL issues with SideMenu library #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n RTL mode, the menu does not correctly render. It should render at the start of the viewport, which would be on the right in RTL mode. Instead it continues to render on the left. `left` and `right` positions are misleading in this library. The intention of `left` and `right` (as per how its coded) is to behave more like `start` and `end` in React Native. - This commit adds some new menuPosition props options for `start` and `end` which are intended to deprecate `left` and `right`. - It also adds a new function to allow calculating whether we should consider the menuPosition as at the 'start' of the viewport which will be left in LTR mode and right in RTL mode. - It also adds a function which uses this new calculation to decide what side the menu should be rendered on.
…hanges. This makes the drawer component responsive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #305
Ive noticed a number of issues with this library when running inside a React Native RTL app (web and native).
This P.R addresses a number of those issues:
notably: