feat: add function to mask address #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieuvo
approved these changes
Jul 4, 2024
hieuvo
reviewed
Jul 4, 2024
| return "", ErrInvalidNumVisibleChars | ||
| } | ||
|
|
||
| prefixLength := len("0x") + numVisibleChars/2 // The number of characters to keep at the start (0x + first some hex digits) |
There was a problem hiding this comment.
minor, numVisibleChars/2 vs numVisibleChars / 2 🤔
There was a problem hiding this comment.
hmm, sometimes go formating is weird https://go.screenpal.com/watch/cZifeCV8zdQ
hieuvo
reviewed
Jul 4, 2024
| // @param numVisibleChars: The number of visible characters to keep at the start and end of the address | ||
| // @param maskedCharacter: The character to use for masking the middle part of the address | ||
| // @return The masked address and error if any | ||
| func MaskAddress(address string, numVisibleChars int, maskedCharacter rune) (string, error) { |
There was a problem hiding this comment.
with negative numVisibleChars, this method will throw panic
panic: runtime error: slice bounds out of range [44:42] [recovered]
panic: runtime error: slice bounds out of range [44:42]
There was a problem hiding this comment.
I pushed a commit to fix this
hieuvo
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did we need it?
Related Issue
Release Note
How Has This Been Tested?
Screenshots (if appropriate):