Trd 251 tradelogs allow register webhook on new trade #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanhpp
reviewed
Apr 12, 2024
| } | ||
|
|
||
| func (b *Broadcaster) addConn(event, maker string, conn *websocket.Conn) { | ||
| ID := xid.New().String() |
There was a problem hiding this comment.
Suggested change
| ID := xid.New().String() | |
| id := xid.New().String() |
Comment on lines
+72
to
+87
| for { | ||
| b.mu.Lock() | ||
| for _, cons := range b.clients { | ||
| for id, c := range cons { | ||
| if _, _, err := c.ws.ReadMessage(); err != nil { | ||
| if websocket.IsCloseError(err, websocket.CloseNormalClosure, websocket.CloseGoingAway, websocket.CloseNoStatusReceived) { | ||
| b.l.Infow("socket is closed", "id", id) | ||
| delete(cons, id) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| b.mu.Unlock() | ||
| time.Sleep(time.Minute) | ||
| } | ||
| } |
There was a problem hiding this comment.
❓ what will be returned if there is no message
There was a problem hiding this comment.
no msg, read message will return nil
Comment on lines
+13
to
+19
|
|
||
| type Con struct { | ||
| id string | ||
| ws *websocket.Conn | ||
| eventHash string | ||
| maker string | ||
| } |
There was a problem hiding this comment.
What if a connection want to subscribe to multiple eventHashes and makers?
There was a problem hiding this comment.
we don't do that here
ngocthanh1389
deleted the
TRD-251-tradelogs-allow-register-webhook-on-new-trade
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.