Skip to content

Commit

Permalink
refactor CUDA versions in dependencies.yaml (rapidsai#671)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#7.

Proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

### Benefits of this change

* prevents accidental inclusion of multiple `cuda-version` version in environments
* reduces update effort (via enabling more use of globs like `"12.*"`)
* improves the chance that errors like "`conda` recipe is missing a dependency" are caught in CI

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham
  - Jake Awe (https://github.com/AyodeAwe)

URL: rapidsai#671
  • Loading branch information
jameslamb authored Jan 11, 2024
1 parent ee30868 commit a3c0f13
Showing 1 changed file with 16 additions and 8 deletions.
24 changes: 16 additions & 8 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ files:
arch: [x86_64]
includes:
- build
- cudatoolkit
- cuda
- cuda_version
- checks
- docs
- py_version
Expand All @@ -16,7 +17,7 @@ files:
test_python:
output: none
includes:
- cudatoolkit
- cuda_version
- py_version
- test_python
checks:
Expand All @@ -27,7 +28,7 @@ files:
docs:
output: none
includes:
- cudatoolkit
- cuda_version
- docs
- py_version
py_build:
Expand Down Expand Up @@ -140,34 +141,41 @@ dependencies:
- output_types: [conda, requirements]
packages:
- pre-commit
cudatoolkit:
cuda_version:
specific:
- output_types: conda
matrices:
- matrix:
cuda: "11.2"
packages:
- cuda-version=11.2
- cudatoolkit
- matrix:
cuda: "11.4"
packages:
- cuda-version=11.4
- cudatoolkit
- matrix:
cuda: "11.5"
packages:
- cuda-version=11.5
- cudatoolkit
- matrix:
cuda: "11.8"
packages:
- cuda-version=11.8
- cudatoolkit
- matrix:
cuda: "12.0"
packages:
- cuda-version=12.0
cuda:
specific:
- output_types: conda
matrices:
- matrix:
cuda: "11.*"
packages:
- cudatoolkit
- matrix:
cuda: "12.*"
packages:
- cuda-cudart-dev
- libnvjpeg-dev
- libcufile-dev
Expand Down

0 comments on commit a3c0f13

Please sign in to comment.