Utility to denoise laser profile and adding a test for the same #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Thanks for this PR! A few general points:
- Good idea to put this in a separate file
denoise.pyas you propose, if we consider having other denoising methods implemented later. Could you adapt the naming etc.? For instance, the function could be called:denoise_LG_modesor so. - I would encourage you to check
mode_decomposition.py, it can take either a full Laser profile or a Transverse profile, and explain what it does in each case. IMO the clearest would be for your function to take a genericprofilethat can be aTransverseProfileor aLaserbut always return aTransverseProfile. In the future, we could always return the same type as input, I think that would be the best, but would take more work to handle the longitudinal data. - Could you avoid ambiguous input arguments like
parametersbundling different variables, unless necessary? Just pass the arguments you need, and no more (for instance you may get rid ofpolarization). - Please document all input parameters, check other functions for example.
- Please add a CI test.
Paaaaarth
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Paaaaarth
changed the title
for more information, see https://pre-commit.ci
Changed the name of variable to try and fix the pre commit bot error.
for more information, see https://pre-commit.ci
|
With D4, We have added the additional capability of inputing an image file as transverse profile. Skimage package is used to extract the intensity data. |
Comment on lines
+78
to
+80
| modeCoeffs, waist = hermite_gauss_decomposition( | ||
| transverse_profile, wavelength, n_modes_x, n_modes_y, resolution, lo, hi | ||
| ) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERGE AFTER #326.
Denoising can be considered as one of the common thing that's done while creating a laser object and yet there is no trivial way to do so in LASY. With this pull request we aim to add this functionality i.e. mode decomposition based denoising. In its current state the code does two distinct things, mode decomposition and creating denoised profile.