Methods deletion simplification and fix

activity_browser/actions/method/method_delete.py

@@ -24,25 +24,19 @@ class MethodDelete(ABAction):
     @staticmethod
     @exception_dialogs
     def run(methods: List[tuple], level: str):
-        # this action can handle only one selected method for now
-        selected_method = methods[0]
-
         # check whether we're dealing with a leaf or node. If it's a node, select all underlying methods for deletion
-        if level is not None and level != "leaf":
-            all_methods = [
-                bd.Method(method)
-                for method in bd.methods
-                if set(selected_method).issubset(method)
-            ]
+        all_methods = [bd.Method(method) for method in methods]
+
+        if len(all_methods) == 1:
+            warning_text = f"Are you sure you want to delete this method?\n\n{methods[0]}"
         else:
-            all_methods = [bd.Method(selected_method)]
+            warning_text = f"Are you sure you want to delete {len(all_methods)} methods?"
 
         # warn the user about the pending deletion
         warning = QtWidgets.QMessageBox.warning(
             application.main_window,
             "Deleting Method",
-            f"Are you sure you want to delete this method and possible underlying "
-            f"methods?\n\n{selected_method}",
+            warning_text,
             QtWidgets.QMessageBox.Yes | QtWidgets.QMessageBox.No,
             QtWidgets.QMessageBox.No,
         )

activity_browser/ui/tables/impact_categories.py

@@ -202,7 +202,7 @@ def selected_methods(self) -> Iterable:
             filter_on = ", ".join(tree_level[1]) + ", "
 
         methods = self.model.get_methods(filter_on)
-        return methods
+        return list(methods)
 
     def tree_level(self) -> tuple:
         """Return list of (tree level, content).