Updated scenario calculations #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od: Used to update the technosphere and biosphere matrices to include the values from Scenarios. Updates now involve the use of copied matrices so that the original database values are not lost and can be used on repeated iterations of scenario calculations. Expected behaviour is, therefore, that each scenario will use self defined values and the values from the database where no value is defined.
|
@bsteubing this should correct for the behaviour that you predicted in the last meeting. This was also the behaviour that confused me and led me to set default values on creating the scenario dataframe. The original approach is ultimately far preferable, but should be more predictable with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bug,feature,ui,change,documentation,breaking,cias they show up in the changelog