Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CF values not updated #1029

Merged
merged 8 commits into from
Sep 8, 2023
Merged

Fix CF values not updated #1029

merged 8 commits into from
Sep 8, 2023

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Sep 4, 2023

CF values now store new value when changed in UI.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog

@marc-vdm marc-vdm added the bug Issues/PRs related to bugs label Sep 4, 2023
Copy link
Contributor

@Zoophobus Zoophobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better, the only thing that can be worked on is the documentation, I know it's a pain but it can help with the code too. Also I think it's good to change the method names (as you have here) to be more descriptive, it adds a surprising amount of clarity

@marc-vdm marc-vdm closed this Sep 7, 2023
@marc-vdm marc-vdm mentioned this pull request Sep 7, 2023
3 tasks
@marc-vdm marc-vdm reopened this Sep 8, 2023
@marc-vdm marc-vdm merged commit 7b8b719 into master Sep 8, 2023
18 checks passed
@marc-vdm marc-vdm deleted the CF_values_not_updating branch May 14, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants