Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic linting #1310

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Automatic linting #1310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
731fb91
Simple Ruff tryout
mrvisscher Jun 10, 2024
5d5eefb
Ignore test
mrvisscher Jun 10, 2024
3f47570
Ignore test
mrvisscher Jun 10, 2024
935b0a6
`check --fix` test
mrvisscher Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ruff.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: Linting
on: [ push, pull_request ]
jobs:
ruff:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: chartboost/ruff-action@v1
with:
args: check --fix
Comment on lines +9 to +10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with:
args: check --fix

Probably don't want to fix on CI, but on the pre-commit hook maybe?

Btw it's a good idea to set your editor (and CI) to ensure files end with a \n [1].

[1] - https://stackoverflow.com/a/729795

2 changes: 2 additions & 0 deletions ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[lint]
#ignore = ["F401", "F403", "F405", "F541", "F821" , "F841", "E713", "E721", "E722", "E741"]
Loading