Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter scenario import bug #1399

Merged

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Oct 14, 2024

Fixes bug where parameter scenario files with only numerical group names are imported as the wrong dtype, which causes joins later in the process to fail.

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Oct 14, 2024
@mrvisscher mrvisscher added this to the 2.10.4 milestone Oct 14, 2024
@coveralls
Copy link

Coverage Status

coverage: 54.21% (+0.03%) from 54.184%
when pulling 4088ed8 on mrvisscher:parameter-scenario-fix
into ffd8534 on LCA-ActivityBrowser:main.

@mrvisscher mrvisscher merged commit 9ace464 into LCA-ActivityBrowser:main Oct 18, 2024
9 checks passed
@mrvisscher mrvisscher deleted the parameter-scenario-fix branch November 8, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants