Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better connection error handling in Project Setup Wizard #1412

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Nov 22, 2024

Adds better exception handling in Project Setup Wizard in two ways:

  1. Special handling for requests.exceptions.ConnectionError
  2. All exceptions will restore the cursor

@marc-vdm no fix needed for safe_link_fetch as there's already general exception handling in place there.

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Nov 22, 2024
@mrvisscher mrvisscher added this to the 2.10.4 milestone Nov 22, 2024
@coveralls
Copy link

Coverage Status

coverage: 54.185% (-0.03%) from 54.21%
when pulling 35bac21 on mrvisscher:request-exceptions
into 9ace464 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm merged commit 023eb5a into LCA-ActivityBrowser:main Nov 26, 2024
9 checks passed
@mrvisscher mrvisscher modified the milestones: 2.10.4, 2.11.0 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AB hangs indefinitely when importing database without network connection
3 participants