-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of HEPMC3 and GENIE Reweight to docker image #105
Open
wesketchum
wants to merge
11
commits into
main
Choose a base branch
from
wketchum_HEPMC3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ed8f2d3
updates to GENIE for reweight/updated container
wesketchum 340a75e
Merge branch 'main' of https://github.com/LDMX-Software/docker
wesketchum a8eda4b
missed a line on the merge conflict
wesketchum 274fbe1
updates for GENIE with pythia8 and reweight
wesketchum fff90a3
Merge branch 'main' of https://github.com/wesketchum/ldmxsw_docker
wesketchum 8fd6c80
Merge branch 'main' of https://github.com/LDMX-Software/docker
wesketchum d092470
Merge remote-tracking branch 'ldmx/main'
wesketchum 88fe974
updates to use hepmc3 as a medium for storing the GENIE event informa…
wesketchum e76a8e4
updates for reweight, and pyhepmc3
wesketchum ec924e1
Merge branch 'main' of https://github.com/LDMX-Software/docker into w…
wesketchum faf2f4a
update genie downloads to be based on set tags
wesketchum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,3 +26,4 @@ uhi==0.3.2 | |
uproot==4.3.7 | ||
wheel==0.37.1 | ||
xgboost==1.7.1 | ||
pyhepmc==2.13.4 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove Pythia6? Is it still necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately still necessary :/ I know the GENIE team is working on it, but I think the Pythia6 dependency is buried deep, and they've not fully extricated it yet. I will double-check to be sure, but unfortunately it's a case where it looks like we need both.