Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GENIE updates, including GENIE Reweight #79

Closed
wants to merge 6 commits into from

Conversation

wesketchum
Copy link
Contributor

I am adding a new package to the container, here are the details.

What new packages does this PR add to the development container?

  • pythia8 (v8.3.10)
  • GENIE v3.4 (update from v3.2)
  • GENIE Reweight

Check List

  • I successfully built the container using docker
# outline of container build instructions
cd docker
git checkout my-updates
docker build . -t ldmx/local:temp-tag
  • I was able to build ldmx-sw using this new container build
# outline of build instructions
ldmx-container-pull local temp-tag
cd ldmx-sw
mkdir build
cd build
ldmx cmake ..
ldmx make install
  • I was able to test run a small simulation and reconstruction inside this container
# outline of test instructions
cd $LDMX_BASE/ldmx-sw/build
ldmx ctest
cd ..
for c in `ls ldmx-sw/*/test/*.py`; ldmx fire $c; done
  • I was able to successfully use the new packages. Explain what you did to test them below:
    Run of GenieGenerator simulation.

@wesketchum
Copy link
Contributor Author

One todo -- use a fork of GENIE Reweight, and properly tag the desired commit (rather than head of master) and pull that down.

Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the specific comments, please add comment in Pythia6 comment block about how it shouldn't be necessary but trying to remove it broke parts (or all?) of GENIE. Just a helpful reminder for future folks who may be updating GENIE to try again.


###############################################################################
# PYTHIA8
###############################################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does Pythia8 require rsync? Does it download stuff from servers during running?

--enable-test \
&& \
make -j$NPROC && \
make -j$NPROC install

#Unfortunately ... need to use the master branch of GENIE reweight...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the SW Dev meeting, we should change this to be a specific commit sha and if possible a specific human-readable tag made by the GENIE folks. Then (whichever path occurs), we should update ENV and LABEL with the version of GENIE Reweight installed.

something like

ENV GENIE_REWEIGHT_VERSION=1_02_03
LABEL genie_reweight.version=${GENIE_REWEIGHT_VERSION}

@wesketchum
Copy link
Contributor Author

Closing this in favor of #105.

@wesketchum wesketchum closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants