-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GENIE updates, including GENIE Reweight #79
Conversation
One todo -- use a fork of GENIE Reweight, and properly tag the desired commit (rather than head of master) and pull that down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the specific comments, please add comment in Pythia6 comment block about how it shouldn't be necessary but trying to remove it broke parts (or all?) of GENIE. Just a helpful reminder for future folks who may be updating GENIE to try again.
|
||
############################################################################### | ||
# PYTHIA8 | ||
############################################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does Pythia8 require rsync
? Does it download stuff from servers during running?
--enable-test \ | ||
&& \ | ||
make -j$NPROC && \ | ||
make -j$NPROC install | ||
|
||
#Unfortunately ... need to use the master branch of GENIE reweight... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the SW Dev meeting, we should change this to be a specific commit sha and if possible a specific human-readable tag made by the GENIE folks. Then (whichever path occurs), we should update ENV
and LABEL
with the version of GENIE Reweight installed.
something like
ENV GENIE_REWEIGHT_VERSION=1_02_03
LABEL genie_reweight.version=${GENIE_REWEIGHT_VERSION}
Closing this in favor of #105. |
I am adding a new package to the container, here are the details.
What new packages does this PR add to the development container?
Check List
Run of GenieGenerator simulation.