-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated functions in ONNX and boost + type conversion for ConfigurePythonTest #1393
Conversation
@tomeichlersmith what do you think about what I did here for boost? This (partially) solves the warning (the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. The deprecation methods within Boost are from the Boost.Python library which we use for the bindings within DetDescr. I'm not super worried about the text changes to the log [0] since the changes are only on a handful of events out of 10k. Maybe the change to Boost is somehow affecting the TDecompSVD class in ROOT? It seems to be an edge case at least.
All I'm worried about is the ONNX change since I'm so unfamiliar with it, but a few test-runs with someone more familiar with the BDT would be able to confirm that GetShape and GetDimension are equivalent for us.
[0] Changes to logs were in the signal validation sample when PR was originally opened.
< [ ecalVeto ] 0 : MIP tracking completed; found 4 straight tracks and 0 lin-reg tracks
---
> [ ecalVeto ] 0 : MIP tracking completed; found 4 straight tracks and 2 lin-reg tracks
13163c13163
< [ ecalVeto ] 0 : MIP tracking completed; found 0 straight tracks and 0 lin-reg tracks
---
> [ ecalVeto ] 0 : MIP tracking completed; found 0 straight tracks and 1 lin-reg tracks
73962c73962
< [ ecalVeto ] 0 : MIP tracking completed; found 2 straight tracks and 0 lin-reg tracks
---
> [ ecalVeto ] 0 : MIP tracking completed; found 2 straight tracks and 1 lin-reg tracks
101379c101379
< [ ecalVeto ] 0 : MIP tracking completed; found 3 straight tracks and 0 lin-reg tracks
---
> [ ecalVeto ] 0 : MIP tracking completed; found 3 straight tracks and 1 lin-reg tracks
Alright, the change in lin-reg tracks within the ECal Veto is still persisting. Here is a quick summary,
While I am mildly curious about the cause behind this, I think it could reasonably be from a change in the underlying runner's software (OS or version of docker for example) that causes a slight change for us. Footnotes
|
I'm not sure that's just not hidden given that the log level is different from the rest of them :/ |
Where did you do this? This LDMX-Software/docker#97 you closed, right? |
No I mean the OS of the runner launched by GitHub. I'd be surprised if that affects things, but throwing stuff out there. You're right about the no change probably being from the log level. |
I tried running locally and the log diff showed even more differences. I need to check my local configuration and stuff but I fear that this is not something that is easy to reproduce and test. |
@tvami I see two ways forward:
What do you think? |
I still havent had the chance to look at the BDT score and other plots in higher stats. It's not a lot of work, I just keep getting distracted with other things :D But yeah let me post some plots by tomorrow. If you want, you can approve based on the code changes, and then I'll post the plots and we can merge later if they look good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks for doing that double check. I feel mich more confident that the log changes are neglible.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #1208
Check List