Allow pre-resolved seeds #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Matthew Clarke <[email protected]>
Seed keyhandle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the config-time loading of seed key materials, only supports key stores where the resolution of a
name/path/indexis a fully-deterministic loading instruction for a key material.However, there are cases where the result of this must be stored back to the DB in key manager when resolving keys. Particularly when using "master key encryption" approaches, where the
keyHandlewill be an encrypted representation of a key that can only be decrypted by the HSM.This PR proposes the
keyHandlecan be supplied directly in the configuration for seed loading, mimicking the post-resolution state - where thekeyHandlehas been persisted. This allows the configuration to:FindOrCreateLoadableKeyLoadKeyMaterial