Update for the SCAN feature #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the job of this PR will be made easier, especially in terms of RGE, once the #96 PR is merged. |
LucaMantani
changed the base branch from
main
to
optimise-rge-matrix-multiplication
LucaMantani
reviewed
Dec 5, 2024
| coeff.value = 0.0 | ||
| coeff.is_free = False |
There was a problem hiding this comment.
@jacoterh @giacomomagni do you know why this was here? I didn't understand it and it seems to be working without it? Or maybe i missed something
There was a problem hiding this comment.
Maybe it is needed for the next iterations, like the comment says?
arossia94
commented
Dec 17, 2024
Yeah, there a couple of things that I do not know if it made totally sense to change, so I'd like @jacoterh to have a look and do the review when he has time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all the latest updates, the SCAN feature seems to have stopped working. This PR is to review it and bring it up to date.
The first commit introduces a hack in the executable that does the chi2 scan for UV models prepared for fits on the mass.