-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding RG to report #110
base: main
Are you sure you want to change the base?
Adding RG to report #110
Conversation
src/smefit/analyze/fisher.py
Outdated
from mpl_toolkits.axes_grid1 import make_axes_locatable | ||
from numpy.f2py.crackfortran import privatepattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think GitHub copilot added this by mistake haha
@@ -113,10 +126,16 @@ def load_configuration(self): | |||
|
|||
def load_datasets(self): | |||
"""Load all datasets.""" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be improved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few comments
Co-authored-by: Luca Mantani <[email protected]>
f"fisher_{fit.name}", | ||
) | ||
links_list.append((f"fisher_{fit.name}", f"Table {fit.label}")) | ||
|
||
if plot is not None: | ||
fit_plot = copy.deepcopy(plot) | ||
fit_plot.pop("together") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line makes it crash in case together is not specified in the runcard. I think it would be better if it is made sure that if it's not there, it gets set to a default value?
This PR includes:
.pkl
file to the result directory/rge
todo:
Comparison between computing the RG from scratch and reloading it:
To enable reloading precomputed RG matrices, one should add its path to the runcard after the key
rg_matrix
The fisher heatmap can be added to the report as follows