Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(core): update sew variants #261

Merged
merged 4 commits into from
Jan 2, 2025
Merged

refactor!(core): update sew variants #261

merged 4 commits into from
Jan 2, 2025

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Jan 2, 2025

Description

Content description:

replaces #247, without the StmError to CMapError auto-coercion. from the old PR:

  • Remove the regular variants and replace it with the try_ variant. The latter has been renamed accordingly
  • The behavior of the force_ variant has not changed, but it is not a wrapper around the regular variant anymore: It ignores attribute-related failure and retry the transaction until complete

Additional information

  • Breaking change

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 84.79263% with 33 lines in your changes missing coverage. Please review.

Project coverage is 77.41%. Comparing base (93416fb) to head (f76711c).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/dim2/sews/two.rs 84.18% 28 Missing ⚠️
honeycomb-core/src/cmap/dim2/sews/one.rs 92.10% 3 Missing ⚠️
honeycomb-core/src/cmap/dim2/sews/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   77.13%   77.41%   +0.28%     
==========================================
  Files          49       49              
  Lines        6801     6784      -17     
==========================================
+ Hits         5246     5252       +6     
+ Misses       1555     1532      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 marked this pull request as ready for review January 2, 2025 09:44
@imrn99 imrn99 merged commit b27fc16 into master Jan 2, 2025
13 checks passed
@imrn99 imrn99 deleted the remove-sew-variants branch January 2, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants