Adding ability to define test space through convex hull #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersonw1
changed the title
andersonw1
requested review from
punkduckable,
dreamer2368,
chldkdtn and
CBonneville45
dreamer2368
reviewed
Nov 10, 2024
There was a problem hiding this comment.
@andersonw1 , most of them look good to me, except the use of getParam1DSpace. I think we can simply use the existing getParam1DSpace functions, not creating a new one. I left some comments in details related to that.
dreamer2368
approved these changes
Nov 13, 2024
src/lasdi/param.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| gridSizes : :obj:`list(Nx)` |
There was a problem hiding this comment.
can we use list(int) instead of list(Nx)?
src/lasdi/param.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| gridSizes : :obj:`list(Nx)` |
There was a problem hiding this comment.
Same as above, can we use list(int) instead of list(Nx)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two things:
We introduce the ability to define training points on the exterior some region of interest. To define the testing points, we first form a uniform grid over the training parameters and then remove all testing points which are not in the convex hull of the training parameters.
This adds the new 'exterior' option for the test_space_type and requires that all of the training points are given as lists. This is useful if we are not interested in sampling from a rectangular grid, and instead have a specific region of interest for the problem. The post-processing files need to be changed.
We now track the training loss and each term of the loss function. These losses are saved with the final output file after training.