Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper files for debuggers #1158

Merged
merged 12 commits into from
Nov 9, 2023
Merged

Helper files for debuggers #1158

merged 12 commits into from
Nov 9, 2023

Conversation

agcapps
Copy link
Member

@agcapps agcapps commented Aug 4, 2023

This PR implements helper files for three popular debuggers.

For MS Visual Studio, a .natvis file; for Totalview, a data display function to implement C++View; for gdb, a Python file. So far, we display conduit::Node objects. Haven't added iterators or other types yet.

Comment on lines +30 to +31
<!-- This works only if the order of the children hasn't been messed up. -->
<!-- I haven't found a way to get a temporary Node here in the loop. -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works in the simple case, for objects that get created and never have Nodes removed. I don't know if I can get this to work in the general case, where the order might get perturbed.

Copy link
Member

@JustinPrivitera JustinPrivitera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool and seems very useful. I look forward to taking advantage of this in the future.

@BradWhitlock
Copy link
Member

@agcapps - this is a terrific idea! I'd like to see a short Sphinx doc page that says how to install/use them with the various debuggers.

@agcapps
Copy link
Member Author

agcapps commented Aug 11, 2023

@JustinPrivitera , thanks!

@BradWhitlock , good idea. I'll add documentation.

@agcapps
Copy link
Member Author

agcapps commented Nov 7, 2023

At this point, I'm stuck on the GDB file. I wrote it as I understood the documentation, and following any examples I could find. So far, the "hash-like" interface for object Nodes does not work.

@cyrush
Copy link
Member

cyrush commented Nov 7, 2023

should we get the others in and add a ticket for full gdb support in the future?

@agcapps
Copy link
Member Author

agcapps commented Nov 7, 2023

should we get the others in and add a ticket for full gdb support in the future?

Yes, I would like to commit. This PR has languished long enough. I'll add some screen shots and clean up construction debris, and mark as "not draft."

@cyrush
Copy link
Member

cyrush commented Nov 7, 2023

Sounds good!

@agcapps agcapps marked this pull request as ready for review November 9, 2023 02:01
@agcapps agcapps merged commit a1e205c into develop Nov 9, 2023
11 of 14 checks passed
@agcapps agcapps deleted the feature/capps2/debughelpers branch November 9, 2023 02:04
@agcapps agcapps mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants