Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update uberenv and related configs #1164

Merged
merged 40 commits into from
Nov 8, 2023
Merged

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Aug 30, 2023

No description provided.

@cyrush
Copy link
Member Author

cyrush commented Sep 5, 2023

First all around successful set of builds, but new spack times are much slower:

  old spack new spack new / old ratio
docker 54 74 1.37
ub18_shared_min_cmake_314 35 42 1.20
ub18_shared_py310_cmake_324_hdf5_114 41 84 2.05
ub18_sahred_py31)cmake_236_hdf5_114 43 72 1.67
ub18_py37_cmake_214 42 70 1.67
ub18_py38_cmake_321_hdf5_110 50 69 1.38
ub18_py38_cmake_321_hdf5_112 49 68 1.39
ub_21_py_38_cmake_321 55 71 1.29

Some of this is b/c we are using less system libs.

We had to exclude:

  • system curl (did not work to build cmake)
  • system xz (caused problems in hdf5 or silo)

I think the big one we are missing is lapack.

That said, even the minimal build is 120% of our prior setup.

Docker builds are timing out on circle CI (circle ci max time is 1 hour, for ref docker build takes 74 minutes now on github actions)

@cyrush
Copy link
Member Author

cyrush commented Sep 5, 2023

external lapack pulls us back from the edge of the cliff for circle ci.

@cyrush
Copy link
Member Author

cyrush commented Sep 5, 2023

Blocking Issue:

Much like PYTHON_EXECUTABLE, we also need to update the path to SPHINX_EXECUTABLE.

Uberenv can do this, however even though it looks like sphinx was built -- I don't see it in the generated spack env view.
Need to investigate if this is a spec issue or some other bug.

@cyrush
Copy link
Member Author

cyrush commented Sep 5, 2023

Spack deps tagged as build don't show up in the env view.

Will see if there is an option to include the, if not I will drop build tag.

@cyrush
Copy link
Member Author

cyrush commented Sep 6, 2023

We can add py-sphinx to the env to have it available in the view.

However, when we do so - the main package concretizes with ~python, which undermines using python in a new way.

Talked to Todd Gamblin, the concretizer is making a strange choice.

I decided the simplest solution is to remove the type="build" from the sphinx deps so they will appear in the env view without extra gymnastics.

@cyrush
Copy link
Member Author

cyrush commented Sep 6, 2023

sphinx 7.0.0 fails to build docs.

seems like an input config file change.

@cyrush
Copy link
Member Author

cyrush commented Nov 3, 2023

Newer spack:
Silo fails to build due to an HDF5 macro issue ?

            MD -MP -MF .deps/H5FDsilo.Tpo -c H5FDsilo.c  -fPIC -DPIC -o .libs/
             H5FDsilo.o
     518     H5FDsilo.c: In function 'file_write':
  >> 519     H5FDsilo.c:265:1: error: expected ';' before '}' token
     520      }
     521      ^
     522     H5FDsilo.c:810:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     523              H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW,
              "addr undefined", -1, -1)
     524              ^~~~~~~~~~~~~~~
  >> 525     H5FDsilo.c:265:1: error: expected ';' before '}' token
     526      }
     527      ^
     528     H5FDsilo.c:81

Looks the same as spack/spack#39538, however our tests aren't running on arm processors.

mpi4py fails to build on m1 mac

==> Installing py-mpi4py-3.1.4-npoddioxajyd3sjvorqawgvootpsehc2 [70/75]
==> No binary for py-mpi4py-3.1.4-npoddioxajyd3sjvorqawgvootpsehc2 found: installing from source
==> Fetching https://mirror.spack.io/_source-cache/archive/17/17858f2ebc623220d0120d1fa8d428d033dde749c4bc35b33d81a66ad7f93480.tar.gz
==> No patches needed for py-mpi4py
==> py-mpi4py: Executing phase: 'install'
==> Error: ProcessError: Command exited with status 1:
    '/Users/harrison37/Work/github/llnl/conduit/uberenv_libs/spack/opt/spack/darwin-ventura-m1/apple-clang-15.0.0/python-3.11.6-teqqopxha5x2pptd2abnw7yuvjeaqff3/bin/python3.11' '-m' 'pip' '-vvv' '--no-input' '--no-cache-dir' '--disable-pip-version-check' 'install' '--no-deps' '--ignore-installed' '--no-build-isolation' '--no-warn-script-location' '--no-index' '--prefix=/Users/harrison37/Work/github/llnl/conduit/uberenv_libs/spack/opt/spack/darwin-ventura-m1/apple-clang-15.0.0/py-mpi4py-3.1.4-npoddioxajyd3sjvorqawgvootpsehc2' '.'

8 errors found in build log:
     97       clang: warning: argument unused during compilation: '-shared' [-Wunused-command-line-argument]
     98       /Users/harrison37/Work/github/llnl/conduit/uberenv_libs/spack/opt/spack/darwin-ventura-m1/apple-clang-15.0.0/openmpi-4.1.6-4fbxie2522twih7jp4vms33vcdbnv2be/b
            in/mpicc -shared -flat_namespace -undefined suppress _configtest.o -llmpe -o _configtest
     99       ld: warning: -undefined suppress is deprecated
     100      ld: warning: -undefined suppress is deprecated
     101      ld: warning: duplicate -rpath '/usr/local/gfortran/lib/' ignored
     102      ld: library 'lmpe' not found
  >> 103    clang: error: linker command failed with exit code 1 (use -v to see invocation)
     104      failure.
     105      removing: _configtest.c _configtest.o
     106      building 'mpe' dylib library
     107      creating build/temp.macosx-13.0-arm64-cpython-311
     108      creating build/temp.macosx-13.0-arm64-cpython-311/src
     109      creating build/temp.macosx-13.0-arm64-cpython-311/src/lib-pmpi

@cyrush
Copy link
Member Author

cyrush commented Nov 7, 2023

need more path adjustments

@cyrush
Copy link
Member Author

cyrush commented Nov 7, 2023

C++ 17 tests are failing often due to MPI related errors.

Not sure if there are real issues, or if this is a setup and tear down MPI issue related to multiple MPI tests.

EXEC : error : Failed to post close command error 1726 

@cyrush cyrush changed the title wip: update uberenv and related configs update uberenv and related configs Nov 8, 2023
@cyrush cyrush merged commit 972d627 into develop Nov 8, 2023
25 checks passed
@cyrush cyrush deleted the task/2023_08_uberenv_update branch November 8, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant