Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Swap now correctly swaps schema parents #1179

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Node Swap now correctly swaps schema parents #1179

merged 5 commits into from
Oct 31, 2023

Conversation

JustinPrivitera
Copy link
Member

@JustinPrivitera JustinPrivitera commented Oct 26, 2023 •
edited
Loading

Resolves #1178

@JustinPrivitera JustinPrivitera mentioned this pull request Oct 26, 2023
Closed
@JustinPrivitera JustinPrivitera marked this pull request as draft October 26, 2023 17:26
@JustinPrivitera JustinPrivitera marked this pull request as ready for review October 26, 2023 17:29
@JustinPrivitera
Copy link
Member Author

all tests pass

@JustinPrivitera

This comment was marked as resolved.

Sign in to view
cyrush
cyrush approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for diving in an fixing this!

@JustinPrivitera JustinPrivitera merged commit e17a944 into develop Oct 31, 2023
24 checks passed
@JustinPrivitera JustinPrivitera deleted the fix/JustinPrivitera/10_26_23/swap_schema_parent branch October 31, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrush cyrush cyrush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confused about move to non-existing subtree
2 participants
@JustinPrivitera @cyrush