Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix cleanup rng omp #2404

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

bvanessen
Copy link
Collaborator

No description provided.

Copy link
Contributor

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean, but there is one comment about the ICC version of the globals

src/utils/random_number_generators.cpp Outdated Show resolved Hide resolved
src/utils/random_number_generators.cpp Outdated Show resolved Hide resolved
sequential and OMP parallel blocks.

Added explict RNGs for OMP parallel blocks.

Fixed the declaration and initialization of OMP RNGs when compiling in
deterministic mode (which disables OMP parallel blocks).

Refactored how the RNGs are saved to and loaded from checkpoints.

Changed the creation of the I/O RNG banks so that there is one bank
per I/O thread.  Removed the option to explicitly set the number of
I/O RNGs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants