New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/arkode sts #541

Merged

gardner48 merged 411 commits into develop from feature/arkode-sts

Nov 15, 2024

Collaborator

maggul commented Jul 12, 2024

This is a draft PR for feedback on new STS module.

maggul added the pkg-ARKODE label

Collaborator

drreynolds commented Jul 12, 2024

Unfortunately, the rebase to develop seems to have marked hundreds of files as conflicts. I'll work on fixing this branch now, so that it will be easier for folks to review.

drreynolds force-pushed the feature/arkode-sts branch from 12940d0 to 62bccbd Compare

July 12, 2024 16:14

Member

balos1 commented Jul 12, 2024

Unfortunately, the rebase to develop seems to have marked hundreds of files as conflicts. I'll work on fixing this branch now, so that it will be easier for folks to review.

Yeah, I think in the future we should not rebase develop on main (if main is updated directly) and instead do a merge. I don't see a real advantage to having the same linear history for main and develop, and it seems the rebase has a pretty big downside.

Collaborator

drreynolds commented Jul 12, 2024

and it seems the rebase has a pretty big downside.

Indeed. Although rebasing might be no big deal for branches with 1-2 commits, it is a huge waste of time for a branch with any appreciable amount of development.

drreynolds reviewed

View reviewed changes

include/arkode/arkode_lsrkstep.h Outdated Show resolved Hide resolved

drreynolds reviewed

View reviewed changes

include/arkode/arkode_lsrkstep.h Outdated Show resolved Hide resolved

drreynolds reviewed

View reviewed changes

include/arkode/arkode_lsrkstep.h Outdated Show resolved Hide resolved

drreynolds reviewed

View reviewed changes

include/arkode/arkode_lsrkstep.h Outdated Show resolved Hide resolved

drreynolds reviewed

View reviewed changes

include/arkode/arkode_lsrkstep.h Outdated Show resolved Hide resolved

drreynolds reviewed

View reviewed changes

include/arkode/arkode_lsrkstep.h Show resolved Hide resolved

drreynolds reviewed

View reviewed changes

include/arkode/arkode_lsrkstep.h Outdated Show resolved Hide resolved

drreynolds reviewed

View reviewed changes

examples/arkode/C_serial/CMakeLists.txt Outdated Show resolved Hide resolved

drreynolds reviewed

View reviewed changes

Collaborator

drreynolds left a comment

I still need to look at the changes in src/arkode, but I wanted to share my comments so far.

examples/arkode/C_serial/erk_analytic.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/erk_analytic.out Outdated Show resolved Hide resolved

examples/arkode/C_serial/ark_analytic.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic_VarJac.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic_VarJac.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic_VarJac.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic_VarJac.c Outdated Show resolved Hide resolved

drreynolds reviewed

View reviewed changes

Collaborator

drreynolds left a comment

One more set of comments, covering the rest of this draft PR.

src/arkode/arkode_lsrkstep_impl.h Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep_impl.h Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep_impl.h Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep_impl.h Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep_io.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

maggul marked this pull request as ready for review

September 9, 2024 16:51

maggul requested review from balos1, gardner48 and cswoodward as code owners

September 9, 2024 16:51

balos1 added this to the SUNDIALS Next milestone

drreynolds requested changes

View reviewed changes

Collaborator

drreynolds left a comment

I've finished reviewing the documentation updates. I'll review the code soon.

CHANGELOG.md Outdated Show resolved Hide resolved

doc/shared/RecentChanges.rst Outdated Show resolved Hide resolved

doc/arkode/guide/source/Constants.rst Show resolved Hide resolved

doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved

doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved

doc/arkode/guide/source/Usage/LSRKStep/User_callable.rst Outdated Show resolved Hide resolved

doc/arkode/guide/source/Usage/LSRKStep/User_callable.rst Outdated Show resolved Hide resolved

doc/arkode/guide/source/Usage/LSRKStep/User_supplied.rst Outdated Show resolved Hide resolved

doc/arkode/guide/source/Usage/LSRKStep/User_supplied.rst Outdated Show resolved Hide resolved

doc/shared/sundials.bib Outdated Show resolved Hide resolved

drreynolds requested changes

View reviewed changes

examples/arkode/C_serial/lsrk_analytic.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic_VarJac.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_analytic_VarJac.c Outdated Show resolved Hide resolved

examples/arkode/C_serial/lsrk_ssp_analytic.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

maggul assigned maggul and unassigned maggul

maggul and others added 5 commits

September 11, 2024 16:38


          Update doc/arkode/guide/source/Usage/LSRKStep/User_callable.rst

cf9ad4f

Co-authored-by: Daniel R. Reynolds <[email protected]>


          Update doc/arkode/guide/source/Usage/LSRKStep/User_callable.rst

5e3f41e

Co-authored-by: Daniel R. Reynolds <[email protected]>


          Update doc/arkode/guide/source/Usage/LSRKStep/User_callable.rst

e5e717f

Co-authored-by: Daniel R. Reynolds <[email protected]>


          Update doc/arkode/guide/source/Usage/LSRKStep/User_callable.rst

dccd7ee

Co-authored-by: Daniel R. Reynolds <[email protected]>


          Update doc/arkode/guide/source/Usage/LSRKStep/User_callable.rst

02705f2

Co-authored-by: Daniel R. Reynolds <[email protected]>

Steven-Roberts reviewed

View reviewed changes

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Show resolved Hide resolved

maggul added 2 commits

November 14, 2024 14:59


          limitting ss by INT_MAX

7e1c978


          number of stages

b7343d5

Steven-Roberts reviewed

View reviewed changes

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved


          round the sqrt

b338d5e

gardner48 reviewed

View reviewed changes

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

include/arkode/arkode.h Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Show resolved Hide resolved

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

gardner48 requested changes

View reviewed changes

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

maggul added 3 commits

November 14, 2024 21:20


          bulk revision

dd93457


          added missing ProcessStages

5bae0c9


          formatting

564778c

drreynolds reviewed

View reviewed changes

Collaborator

drreynolds left a comment

One minor item (I'll commit it myself in a moment).

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved


          Update src/arkode/arkode_lsrkstep.c

345727e

Broke long comment into multiple lines.

drreynolds previously approved these changes

View reviewed changes


          Fixed .out file for Jenkins

8beca20

drreynolds dismissed their stale review via

8beca20

November 15, 2024 16:33

drreynolds previously approved these changes

View reviewed changes


          change tabs to spaces

73ec224

gardner48 dismissed drreynolds’s stale review via

73ec224

November 15, 2024 18:37

gardner48 requested changes

View reviewed changes

src/arkode/arkode_lsrkstep.c Outdated Show resolved Hide resolved

maggul and others added 3 commits

November 15, 2024 14:42


          fn to tempv3

f783984


          update fn_is_current flag

1d49b2d


          remove trailing whitespace

38a4974

gardner48 reviewed

View reviewed changes

Member

gardner48 left a comment

This looks good. Once the CI passes I'll merge sundials-codes/answers#39 and update the submodule here.


          apply formatting

a2936e8

gardner48 pushed a commit to sundials-codes/answers that referenced this pull request


          Feature/arkode sts (#39)

5dca98a

Output files for LSRKStep, see LLNL/sundials#541

gardner48 added 2 commits

November 15, 2024 13:41


          update answers submodule

88166f1


          update out files

156ecd3

gardner48 approved these changes

View reviewed changes

gardner48 merged commit a3fa77f into develop

30 checks passed

gardner48 deleted the feature/arkode-sts branch

November 15, 2024 23:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Steven-Roberts Steven-Roberts left review comments

gardner48 gardner48 approved these changes

drreynolds drreynolds left review comments

balos1 balos1 left review comments

cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

Labels