-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RGB "decentralized geneses": contract unowned extensions & valencies implementation #112
Conversation
4bc2d52
to
453fb27
Compare
854ee48
to
4377e5d
Compare
453fb27
to
3e4d39e
Compare
Noted, will work on the test updates. |
Yeah. Finally managed to push it. |
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
========================================
- Coverage 57.9% 57.5% -0.4%
========================================
Files 59 59
Lines 6581 6851 +270
========================================
+ Hits 3810 3941 +131
- Misses 2771 2910 +139
Continue to review full report at Codecov.
|
@rajarshimaitra can you also pls work on adding cases to existing tests here so we would not forget it later? (I.e. don't write new tests; just add coverage for new fields when needed if the test for other fields/structures are already in place) UPD: if this is already done, just let me know and I will merge |
See LNP-BP/LNPBPs#52 for explanations. This PR implements:
@rajarshimaitra can you pls update test data to make tests not failing? And we need to add test coverage where it is missed.