-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Matching Notebooks #478
Conversation
@drphilmarshall @jiwoncpark @dannygoldstein This PR isn't quite ready but I just wanted it here for you all to follow along. These notebooks will have do 2 things as mentioned in #477 |
Ok, these are ready for comments. Basically, If @drphilmarshall and @jiwoncpark could look over The other notebook I think the final thing I discussed with @jiwoncpark was making sure that the final matched AGN systems are good for analysis in DC2 and this will have to wait until we run all these notebooks with the final DC2 but I have included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @jbkalmbach ! Just looking at the matching lens galaxies notebook, I have some comments:
-
The BIC analysis suggests that only a small number of Gaussians are justified by the data, I think you are right to try to get away with just one. Still, I worry that with the SL2S sample so small, you will overfit the training sample. I didn't see any cross validation happening, to find the GMM parameters that minimize the generalized error, so I wasn't too surprised to see the model misfitting some of the test set. On the whole, I think it's unlikely that you are in danger of overfitting to the whole SL2S sample with 1, 2 or 3 Gaussians, so am inclined to recommend that, just this once, you don't bother with the training/test split, but instead just model the whole SL2S sample and go with that. What do you think? At least, it'd be good to see the training points as well as the test points, overlaid on the predictions in the corner plot.
-
I agree that the radius is still unlikely to be well fitted, so its maybe worth ignoring this from the start (having explained that you can't model it).
-
All plots need axis labels.
-
I would expect the lens galaxy SEDs to come out as being early type spectra with low metallicity and old (~few to 10 Gyr) ages. Is that what you see? The final example seems to have an "Exp" SED, which got me worried.
Hi @drphilmarshall. I have updated the notebooks based upon your comments and used the cosmoDC2 v1.0 galaxies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty sweet, @jbkalmbach - I think the 1-Gaussian GMM is working well. You could clean up the notebook by either reducing the 2 and 3 Gaussian tests to a bare minimum, or just make sure that the narrative make sense in terms of your choices of the number of Gaussian components.Overall though I agree with your final conclusion - looks good!
I've updated the caching files for |
Great! Thanks Bryce.
|
Update matching notebooks to use
gcr-catalogs
. Also make sure that they are doing what we want for DC2.