-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yanza/custom useful clusters #7
Conversation
…rail_som into user/joselotl/neff_bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 319 322 +3
=========================================
+ Hits 319 322 +3
☔ View full report in Codecov by Sentry. |
I changed this PR to a draft so @yanzastro can separate out the good/bad cluster definition as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine. Sorry for taking so long to do the review
missed one of two things I needed to change to fix the nan issue
Thanks for your patience with my review! This looks fine, but I noticed the code for defining bad clusters is still bundled in with the Summarizer rather than separated out as a Classifier that could be used more generically. Is there a reason for this? |
This PR adds a parameter to the somoclu summarizer so that the user can customize which clusters are calibrated. This function is useful when we do quality control by ignoring "bad clusters".
Change Description
Solution Description
Code Quality