Overhaul internals to remove "axis artist" usage and improve flexibility (new version 2.0!) #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating the transformer object turned out to be the major bottleneck, and caching this speeds up repeated transformations 60x.
This allows simpler calls, and will always do Plate Carree to/from the desired transformation because that's the only operation that is useful to skyproj.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a complete overhaul of the internals of skyproj.
The matplotlib AxisArtist code was brittle and would change randomly from sub-version to sub-version. This overhaul removes use of the AxisArtist and move the required functionality into the
SkyAxesclass which makes editing the formatting of plots a lot more flexible. Furthermore, interactivity works again on matplotlib 3.9!The projection code was also simplified to use better caching, and to remove unneeded complexity that allowed transformation from any two coordinate reference systems, but this was never used because we only go from lon/lat to/from a CRS.
The tick labeling has also been simplified internally because we no longer have to work around AxisArtist limitations.
The test plots have all been updated because positions of labels and ticks have moved slightly with the new internals. All the plots look as good or better than the previous versions to my eye. The labeling on arbitrary Albers maps is still a little wonky, but it was wonky before.